Repository navigation
fix: verify the whole core on release; core.sh never reads errors as "not released" - #5
Merged
carlosthe19916 merged 1 commit intoNov 15, 2026
Conversation
…"not released" From a verification of the whole release: - core.sh swallowed network and GitHub errors as "not released", so a tampered xhandler.wasm passed make verify-core whenever GitHub failed. Downloads now fail on anything but 200 or 404. - make verify-release also re-syncs the release and fails if anything make sync writes differs (wasm, VERSION, models, conformance corpus), not only the wasm checksum. - Versions are X.Y.Z or X.Y.Z-(alpha|beta|rc).N, as release-tools releases; a leading v and a CRLF VERSION are accepted; missing arguments print the usage. - release.yml has run-name "Release <tag>", which release-tools uses to find the run of a release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from an independent verification of the whole release (a fake xhandler-rust release served locally, with failure cases):
core.shswallowed network and GitHub errors as "not released", so a tamperedxhandler.wasmpassedmake verify-corewhenever GitHub failed. Downloads now fail on anything but 200 or 404.make verify-releasealso re-syncs the release and fails if anythingmake syncwrites differs (wasm,VERSION, models, conformance corpus), not only the wasm checksum.X.Y.ZorX.Y.Z-(alpha|beta|rc).N, as release-tools releases. A leadingvand a CRLFVERSIONare accepted, and missing arguments print the usage.run-name: Release <tag>inrelease.yml, which release-tools uses to find the run of a release.Tested: synced release passes; an edited model, an unknown version, a bad version form and the network down all fail with the reason; a CRLF
VERSIONpasses.🤖 Generated with Claude Code