Skip to content

fix: verify the whole core on release; core.sh never reads errors as "not released" - #5

Merged
carlosthe19916 merged 1 commit into
project-openubl:mainfrom
carlosthe19916:fix/release-verification
Nov 15, 2026
Merged

carlosthe19916 merged 1 commit into
project-openubl:mainfrom
carlosthe19916:fix/release-verification

Conversation

@carlosthe19916

Copy link
Copy Markdown
Member

Fixes from an independent verification of the whole release (a fake xhandler-rust release served locally, with failure cases):

  • Errors are no longer "not released": core.sh swallowed network and GitHub errors as "not released", so a tampered xhandler.wasm passed make verify-core whenever GitHub failed. Downloads now fail on anything but 200 or 404.
  • The whole core is verified: make verify-release also re-syncs the release and fails if anything make sync writes differs (wasm, VERSION, models, conformance corpus), not only the wasm checksum.
  • Versions are X.Y.Z or X.Y.Z-(alpha|beta|rc).N, as release-tools releases. A leading v and a CRLF VERSION are accepted, and missing arguments print the usage.
  • run-name: Release <tag> in release.yml, which release-tools uses to find the run of a release.

Tested: synced release passes; an edited model, an unknown version, a bad version form and the network down all fail with the reason; a CRLF VERSION passes.

🤖 Generated with Claude Code

…"not released"

From a verification of the whole release:

- core.sh swallowed network and GitHub errors as "not released", so a
  tampered xhandler.wasm passed make verify-core whenever GitHub failed.
  Downloads now fail on anything but 200 or 404.
- make verify-release also re-syncs the release and fails if anything
  make sync writes differs (wasm, VERSION, models, conformance corpus),
  not only the wasm checksum.
- Versions are X.Y.Z or X.Y.Z-(alpha|beta|rc).N, as release-tools
  releases; a leading v and a CRLF VERSION are accepted; missing
  arguments print the usage.
- release.yml has run-name "Release <tag>", which release-tools uses to
  find the run of a release.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@carlosthe19916
carlosthe19916 merged commit 496a917 into project-openubl:main Nov 15, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant